[
https://issues.apache.org/jira/browse/BEAM-3061?focusedWorklogId=259045&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259045
]
ASF GitHub Bot logged work on BEAM-3061:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/19 20:25
Start Date: 12/Jun/19 20:25
Worklog Time Spent: 10m
Work Description: steveniemitz commented on issue #7805: [BEAM-3061] Done
notifications for BigtableIO.Write
URL: https://github.com/apache/beam/pull/7805#issuecomment-501441653
> @steveniemitz From the description ` A common use-case of this is to wait
for all writes to finish, and then do something else` isn't this what basic
`Wait` does? What is the use case of doing this per bundle? (just trying to
understand).
I don't see any great use-case for per-bundle, but `Wait.on` needs some kind
of trigger, which is what this provides (you can't Wait.on a PDone). If there
were a simple way to have this only emit one element per-window, that'd be
cool, but I can't think of anything efficient off the top of my head that
wouldn't involve a reshuffle.
For example, in our topologies, we hook up a `Sample.any` after the
BigtableIO.Write (and remove all triggers from the input), which gives us a
single firing when the window closes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 259045)
Time Spent: 4h (was: 3h 50m)
> BigtableIO should support emitting a sentinel "done" value when a bundle
> completes
> ----------------------------------------------------------------------------------
>
> Key: BEAM-3061
> URL: https://issues.apache.org/jira/browse/BEAM-3061
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> There was some discussion of this on the dev@ mailing list [1]. This
> approach was taken based on discussion there.
> [1]
> https://lists.apache.org/thread.html/949b33782f722a9000c9bf9e37042739c6fd0927589b99752b78d7bd@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
