[
https://issues.apache.org/jira/browse/BEAM-7543?focusedWorklogId=259579&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259579
]
ASF GitHub Bot logged work on BEAM-7543:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/19 13:40
Start Date: 13/Jun/19 13:40
Worklog Time Spent: 10m
Work Description: je-ik commented on issue #8848: [BEAM-7543]
ReduceByKey.combineBy must accept BinaryFunction<V, V, V>
URL: https://github.com/apache/beam/pull/8848#issuecomment-501707520
Note that there is a slight breaking change. `combineBy(Sums.ofLongs())` no
longer takes type parameter, because it is contained in the value returned from
`Sums.ofLongs()`. I hope that this change is so tiny we can afford to take it.
If not, only option would be to add the parameter back, deprecate it and check
that the value passed to this is the same as returned by `Sums.ofLongs()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 259579)
Time Spent: 0.5h (was: 20m)
> ReduceByKey.combineBy must accept BinaryFunction<V, V, V>
> ---------------------------------------------------------
>
> Key: BEAM-7543
> URL: https://issues.apache.org/jira/browse/BEAM-7543
> Project: Beam
> Issue Type: Improvement
> Components: dsl-euphoria
> Affects Versions: 2.13.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When combing associative commutative function directly, the translation can
> be done more effectively, then when we have to resort to reducing Stream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
