[
https://issues.apache.org/jira/browse/BEAM-7541?focusedWorklogId=259800&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259800
]
ASF GitHub Bot logged work on BEAM-7541:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/19 17:54
Start Date: 13/Jun/19 17:54
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #8835: [BEAM-7541]
provide runner & filesystem deps for IOIT in runtime
URL: https://github.com/apache/beam/pull/8835#discussion_r293502238
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1281,20 +1281,20 @@ class BeamModulePlugin implements Plugin<Project> {
/* include dependencies required by runners */
//if (runner?.contains('dataflow')) {
if (runner?.equalsIgnoreCase('dataflow')) {
- testCompile it.project(path: ":runners:google-cloud-dataflow-java",
configuration: 'testCompile')
- shadow it.project(path:
":runners:google-cloud-dataflow-java:worker:legacy-worker", configuration:
'shadow')
+ testCompile it.project(path: ":runners:google-cloud-dataflow-java",
configuration: 'testRuntime')
+ testCompile it.project(path:
":runners:google-cloud-dataflow-java:worker:legacy-worker", configuration:
'testRuntime')
Review comment:
Since legacy-worker is still shading, you need to use the shadow
configuration when referring to it.
```suggestion
testCompile it.project(path:
":runners:google-cloud-dataflow-java:worker:legacy-worker", configuration:
'shadow')
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 259800)
Time Spent: 1h (was: 50m)
> IOIT tests are failing on dataflow due to shading being turned off
> ------------------------------------------------------------------
>
> Key: BEAM-7541
> URL: https://issues.apache.org/jira/browse/BEAM-7541
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Lukasz Gajowy
> Assignee: Lukasz Gajowy
> Priority: Major
> Fix For: 2.14.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> After merging this change IOITs started failing:
> [https://github.com/apache/beam/pull/8762]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
