[ 
https://issues.apache.org/jira/browse/BEAM-7495?focusedWorklogId=260685&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-260685
 ]

ASF GitHub Bot logged work on BEAM-7495:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jun/19 19:46
            Start Date: 14/Jun/19 19:46
    Worklog Time Spent: 10m 
      Work Description: aryann commented on pull request #8832: [BEAM-7495] Add 
dynamic worker rebalancing to BigQuery Storage
URL: https://github.com/apache/beam/pull/8832#discussion_r293951677
 
 

 ##########
 File path: 
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java
 ##########
 @@ -622,40 +657,6 @@ public void testStreamSourceSplit() throws Exception {
     assertThat(streamSource.split(0, options), 
containsInAnyOrder(streamSource));
   }
 
-  @Test
-  public void testStreamSourceGetMaxEndOffset() throws Exception {
-
-    BigQueryStorageStreamSource<TableRow> streamSource =
-        BigQueryStorageStreamSource.create(
-            ReadSession.getDefaultInstance(),
 
 Review comment:
   #getMaxEndOffset and #createSourceForSubrange are properties of 
OffsetBasedSource. I switched the BigQuery Storage source to be a 
BoundedSource, which does not have these properties.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 260685)
            Time Spent: 2h  (was: 1h 50m)
    Remaining Estimate: 502h  (was: 502h 10m)

> Add support for dynamic worker re-balancing when reading BigQuery data using 
> Cloud Dataflow
> -------------------------------------------------------------------------------------------
>
>                 Key: BEAM-7495
>                 URL: https://issues.apache.org/jira/browse/BEAM-7495
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-java-gcp
>            Reporter: Aryan Naraghi
>            Assignee: Aryan Naraghi
>            Priority: Major
>   Original Estimate: 504h
>          Time Spent: 2h
>  Remaining Estimate: 502h
>
> Currently, the BigQuery connector for reading data using the BigQuery Storage 
> API does not support any of the facilities on the source for Dataflow to 
> split streams.
>  
> On the server side, the BigQuery Storage API supports splitting streams at a 
> fraction. By adding support to the connector, we enable Dataflow to split 
> streams, which unlocks dynamic worker re-balancing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to