[
https://issues.apache.org/jira/browse/BEAM-5315?focusedWorklogId=261975&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261975
]
ASF GitHub Bot logged work on BEAM-5315:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/19 02:23
Start Date: 18/Jun/19 02:23
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8878: [BEAM-5315]
improve test coverage bigquery special chars
URL: https://github.com/apache/beam/pull/8878#discussion_r294587655
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py
##########
@@ -96,6 +96,29 @@ def create_table(self, tablename):
self.bigquery_client.insert_rows(
self.project, self.dataset_id, tablename, table_data)
+ def create_table_non_ascii(self, tablename):
+ table_schema = bigquery.TableSchema()
+ table_field = bigquery.TableFieldSchema()
+ table_field.name = 'str'
+ table_field.type = 'STRING'
+ table_schema.fields.append(table_field)
+ table = bigquery.Table(
+ tableReference=bigquery.TableReference(
+ projectId=self.project,
+ datasetId=self.dataset_id,
+ tableId=tablename),
+ schema=table_schema)
+ request = bigquery.BigqueryTablesInsertRequest(
+ projectId=self.project, datasetId=self.dataset_id, table=table)
+ self.bigquery_client.client.tables.Insert(request)
+ table_data = [
+ {'str': '你好'},
Review comment:
I'd suggest we combine this scenario with standard read scenario to avoid
starting extra pipeline and reduce flakiness. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 261975)
Time Spent: 20h 40m (was: 20.5h)
> Finish Python 3 porting for io module
> -------------------------------------
>
> Key: BEAM-5315
> URL: https://issues.apache.org/jira/browse/BEAM-5315
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Juta Staes
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 20h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
