[
https://issues.apache.org/jira/browse/BEAM-4152?focusedWorklogId=265794&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-265794
]
ASF GitHub Bot logged work on BEAM-4152:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jun/19 16:21
Start Date: 24/Jun/19 16:21
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #8111: [BEAM-4152]
Kinds & URNs for Session Windows
URL: https://github.com/apache/beam/pull/8111#discussion_r296805415
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/coder.go
##########
@@ -39,6 +39,7 @@ const (
urnGlobalWindow = "beam:coder:global_window:v1"
urnIntervalWindow = "beam:coder:interval_window:v1"
+ urnSessionWindow = "beam:coder:session_window:v1"
Review comment:
If you want to use a well known name which isn't scoped to Go, you'll want
to add it to the set here
https://github.com/apache/beam/blob/e0cbd2aa7e371c75511544ab78075d54f3f086ca/model/pipeline/src/main/proto/beam_runner_api.proto#L616
The other well known window coders don't do a good job of it but you should
really specify the encoding, look at beam:coder:iterable:v1 or
beam:coder:timer:v1 for examples.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 265794)
Time Spent: 3h 50m (was: 3h 40m)
> Support Go session windowing
> ----------------------------
>
> Key: BEAM-4152
> URL: https://issues.apache.org/jira/browse/BEAM-4152
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Support session windowing and how to handle merging windows.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
