[
https://issues.apache.org/jira/browse/BEAM-5191?focusedWorklogId=266992&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-266992
]
ASF GitHub Bot logged work on BEAM-5191:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/19 19:35
Start Date: 25/Jun/19 19:35
Worklog Time Spent: 10m
Work Description: jklukas commented on pull request #7061: [BEAM-5191]
Support for BigQuery clustering
URL: https://github.com/apache/beam/pull/7061#discussion_r297358761
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java
##########
@@ -292,7 +292,7 @@ private WriteResult
expandTriggered(PCollection<KV<DestinationT, TableRow>> inpu
.apply(WithKeys.of((Void) null))
.setCoder(
KvCoder.of(
- VoidCoder.of(), KvCoder.of(TableDestinationCoderV2.of(),
StringUtf8Coder.of())))
+ VoidCoder.of(), KvCoder.of(TableDestinationCoderV3.of(),
StringUtf8Coder.of())))
Review comment:
For this particular instance, I think we can safely continue to use
TableDestinationCoderV2 since none of the subsequent processing steps in this
method reference the clustering configuration. The TableDestinations we code
here are used to configure a copy job, which does not need to know about
clustering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 266992)
Time Spent: 7.5h (was: 7h 20m)
> Add support for writing to BigQuery clustered tables
> ----------------------------------------------------
>
> Key: BEAM-5191
> URL: https://issues.apache.org/jira/browse/BEAM-5191
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Affects Versions: 2.6.0
> Reporter: Robert Sahlin
> Assignee: Wout Scheepers
> Priority: Minor
> Labels: features, newbie
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> Google recently added support for clustered tables in BigQuery. It would be
> useful to set clustering columns the same way as for partitioning. It should
> support multiple fields (4) for clustering.
> For example:
> [BigQueryIO.Write|https://beam.apache.org/documentation/sdks/javadoc/2.6.0/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.Write.html]<[T|https://beam.apache.org/documentation/sdks/javadoc/2.6.0/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.Write.html]>
> .withClustering(new Clustering().setField("productId").setType("STRING"))
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
