[
https://issues.apache.org/jira/browse/BEAM-7389?focusedWorklogId=270531&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-270531
]
ASF GitHub Bot logged work on BEAM-7389:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/19 00:08
Start Date: 02/Jul/19 00:08
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8904: [BEAM-7389]
Add Python snippet for Partition transform
URL: https://github.com/apache/beam/pull/8904#discussion_r299248528
##########
File path:
sdks/python/apache_beam/examples/snippets/transforms/element_wise/partition_test.py
##########
@@ -0,0 +1,87 @@
+# coding=utf-8
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from __future__ import absolute_import
+from __future__ import print_function
+
+import unittest
+
+import mock
+
+from apache_beam.examples.snippets.transforms.element_wise.partition import *
Review comment:
In my opinion, lack of visibility which namespace the function comes from
confuses the reader. I actually was confused at first glance once quick search
in the test module did not show the functions referenced, but then I saw the
star import. It is also discouraged by
https://www.python.org/dev/peps/pep-0008/#imports. I would suggest to clean it
up in other snippets of this kind in a separate PR.
Note that instead of importing individual function you could import the
module, e.g. `partition`, then it would be more clear that
`partition.partition_function()` comes from `partition`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 270531)
Time Spent: 20h (was: 19h 50m)
> Colab examples for element-wise transforms (Python)
> ---------------------------------------------------
>
> Key: BEAM-7389
> URL: https://issues.apache.org/jira/browse/BEAM-7389
> Project: Beam
> Issue Type: Improvement
> Components: website
> Reporter: Rose Nguyen
> Assignee: David Cavazos
> Priority: Minor
> Time Spent: 20h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
