[
https://issues.apache.org/jira/browse/BEAM-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877202#comment-16877202
]
Valentyn Tymofieiev commented on BEAM-7674:
-------------------------------------------
Dataflow runner tests suites don't separate between Batch and Streaming tests
in test suites:
https://github.com/apache/beam/blob/7f8359940502ea3b9b88ff429807989179417c5c/sdks/python/test-suites/dataflow/build.gradle#L35,
however somehow Dataflow runner correctly launches streaming tests as
streaming jobs. I couldn't immediately see whether it's is a behavior of
Dataflow runner to distinguish between Batch/Streaming jobs based on pipeline,
or some bits of test infrastructure pass --streaming flag for streaming tests.
[~angoenka] [~altay] do you know whether passing --streaming for streaming
pipelines is required in Dataflow runner?
> Define streaming ITs tests for direct runner in consistent way in Python 2
> and Python 3 suites.
> ------------------------------------------------------------------------------------------------
>
> Key: BEAM-7674
> URL: https://issues.apache.org/jira/browse/BEAM-7674
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Valentyn Tymofieiev
> Priority: Major
>
> Currently in Python 2 direct runner test suite some tests run in streaming
> mode:
> https://github.com/apache/beam/blob/fbd1f4cf7118c7b2fb4e3a4cf46646e98f3e3b8d/sdks/python/build.gradle#L130
> However in Python 3, we run both Batch and Streaming direct runner tests in
> Batch mode:
> https://github.com/apache/beam/blob/fbd1f4cf7118c7b2fb4e3a4cf46646e98f3e3b8d/sdks/python/test-suites/direct/py35/build.gradle#L32
> We should check whether we need to explicitly separate the tests into batch
> and streaming and define all directrunner suites consistently.
> cc: [~Juta]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
