[
https://issues.apache.org/jira/browse/BEAM-7665?focusedWorklogId=271807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-271807
]
ASF GitHub Bot logged work on BEAM-7665:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/19 18:21
Start Date: 03/Jul/19 18:21
Worklog Time Spent: 10m
Work Description: htyleo commented on pull request #8976: [BEAM-7665]
Support TypeDefinition options in beam.Combine()
URL: https://github.com/apache/beam/pull/8976#discussion_r300096441
##########
File path: sdks/go/pkg/beam/combine.go
##########
@@ -23,22 +23,24 @@ import (
// Combine inserts a global Combine transform into the pipeline. It
// expects a PCollection<T> as input where T is a concrete type.
-func Combine(s Scope, combinefn interface{}, col PCollection) PCollection {
- return Must(TryCombine(s, combinefn, col))
+// Combine supports only TypeDefinition options, not side inputs.
Review comment:
Thanks! I have revised the comments accordingly. PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 271807)
Time Spent: 40m (was: 0.5h)
> Support TypeDefinition options in beam.Combine()
> ------------------------------------------------
>
> Key: BEAM-7665
> URL: https://issues.apache.org/jira/browse/BEAM-7665
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Tianyang Hu
> Assignee: Tianyang Hu
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Today, CombineFn's output type must be either concrete or a generic type that
> can be inferred from the input type. This doesn't work if the input type is
> struct\{U, V\} while the output type is V (where U and V are generic types).
> Similar to ParDo, we could add TypeDefinition options support to Combine.
> This will bind generic types in the CombineFn to the specified concrete types
> at pipeline construction time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
