[
https://issues.apache.org/jira/browse/BEAM-7668?focusedWorklogId=273510&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-273510
]
ASF GitHub Bot logged work on BEAM-7668:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/19 20:15
Start Date: 08/Jul/19 20:15
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #8977: [BEAM-7668]
Add GetPipeline method to gRPC JobService
URL: https://github.com/apache/beam/pull/8977#discussion_r301280475
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/jobsubmission/InMemoryJobService.java
##########
@@ -234,6 +237,26 @@ public void getState(
}
}
+ @Override
+ public void getPipeline(
+ GetJobPipelineRequest request, StreamObserver<GetJobPipelineResponse>
responseObserver) {
+ LOG.trace("{} {}", GetJobPipelineRequest.class.getSimpleName(), request);
+ String invocationId = request.getJobId();
+ try {
+ JobInvocation invocation = getInvocation(invocationId);
+ RunnerApi.Pipeline pipeline = invocation.getPipeline();
Review comment:
Again, I copied the API contract from `getState`, and handled the error case
in exactly the same way, so if it's not correct for `getPipeline`, that's
because it's not correct for `getState` or the other 4 methods that use this
same pattern.
In case of error it's responding with the exception:
```java
catch (Exception e) {
...
responseObserver.onError(Status.INTERNAL.withCause(e).asException());
}
```
I'm new to Java, so I just assumed this was responding with `NOT_FOUND` in
the case that `getInvocation(invocationId)` failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 273510)
Time Spent: 1h 40m (was: 1.5h)
> Add ability to query a pipeline from a gRPC JobService
> ------------------------------------------------------
>
> Key: BEAM-7668
> URL: https://issues.apache.org/jira/browse/BEAM-7668
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Labels: portability
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> As a developer I want to query the pipeline definition of jobs that have
> already been submitted to the Job Service, so that I can write a UI to view
> and monitor Beam pipelines via the portability model.
>
> PR is coming soon!
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
