[
https://issues.apache.org/jira/browse/BEAM-5191?focusedWorklogId=273514&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-273514
]
ASF GitHub Bot logged work on BEAM-5191:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/19 20:18
Start Date: 08/Jul/19 20:18
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #8945: [BEAM-5191] Support
for BigQuery clustering
URL: https://github.com/apache/beam/pull/8945#issuecomment-509375876
A "good enough" solution might be to always print a warning when clustering
is not enabled. We will want to wordsmith the warning so it's not too
frightening, and it's clear that it only applies if trying to specify
clustering.
On Mon, Jul 8, 2019 at 1:11 PM Jeff Klukas <[email protected]> wrote:
> There is no warning at this point. For the case of loading to an existing
> table, the operation will throw exceptions anyway if clustering is
> mismatched. Perhaps there are compile time cases we could warn about.
>
> I will have to think more about when I'm back in office next week if we
> want to block on that.
>
> On Mon, Jul 8, 2019, 1:06 PM reuvenlax <[email protected]> wrote:
>
> > *@reuvenlax* commented on this pull request.
> > ------------------------------
> >
> > In
> >
>
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableDestinationCoderV3.java
> > <https://github.com/apache/beam/pull/8945#discussion_r301203857>:
> >
> > > + */
> > +package org.apache.beam.sdk.io.gcp.bigquery;
> > +
> > +import java.io.IOException;
> > +import java.io.InputStream;
> > +import java.io.OutputStream;
> > +import org.apache.beam.sdk.coders.AtomicCoder;
> > +import org.apache.beam.sdk.coders.Coder;
> > +import org.apache.beam.sdk.coders.NullableCoder;
> > +import org.apache.beam.sdk.coders.StringUtf8Coder;
> > +
> > +/**
> > + * A {@link Coder} for {@link TableDestination} that includes time
> partitioning and clustering
> > + * information. Users must opt in to this version of the coder by
> setting one of the clustering
> > + * options on {@link BigQueryIO.Write}, otherwise {@link
> TableDestinationCoderV2} will be used and
> > + * clustering information will be discarded.
> >
> > if a user forgets to set a clustering option but creates a
> > TableDestination with clustering information, will we warn them or just
> > silently discard?
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <
>
https://github.com/apache/beam/pull/8945?email_source=notifications&email_token=AAFIW5DW44XOYCDV56PR263P6NXZFA5CNFSM4H3LPCH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5YJ5IY#pullrequestreview-259038883
> >,
> > or mute the thread
> > <
>
https://github.com/notifications/unsubscribe-auth/AAFIW5HCBJWDJJP3EH4GJE3P6NXZFANCNFSM4H3LPCHQ
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/8945?email_source=notifications&email_token=AFAYJVMDVF3DPJ4JDFBEIJLP6ONN3A5CNFSM4H3LPCH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZOGXUY#issuecomment-509373395>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AFAYJVKO7SCMPFTQGZWTTLTP6ONN3ANCNFSM4H3LPCHQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 273514)
Time Spent: 13h (was: 12h 50m)
> Add support for writing to BigQuery clustered tables
> ----------------------------------------------------
>
> Key: BEAM-5191
> URL: https://issues.apache.org/jira/browse/BEAM-5191
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Affects Versions: 2.6.0
> Reporter: Robert Sahlin
> Assignee: Wout Scheepers
> Priority: Minor
> Labels: features, newbie
> Time Spent: 13h
> Remaining Estimate: 0h
>
> Google recently added support for clustered tables in BigQuery. It would be
> useful to set clustering columns the same way as for partitioning. It should
> support multiple fields (4) for clustering.
> For example:
> [BigQueryIO.Write|https://beam.apache.org/documentation/sdks/javadoc/2.6.0/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.Write.html]<[T|https://beam.apache.org/documentation/sdks/javadoc/2.6.0/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.Write.html]>
> .withClustering(new Clustering().setField("productId").setType("STRING"))
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
