[
https://issues.apache.org/jira/browse/BEAM-6480?focusedWorklogId=273941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-273941
]
ASF GitHub Bot logged work on BEAM-6480:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/19 09:54
Start Date: 09/Jul/19 09:54
Worklog Time Spent: 10m
Work Description: RyanSkraba commented on pull request #9005: [BEAM-6480]
Adds AvroIO sink for generic records.
URL: https://github.com/apache/beam/pull/9005#discussion_r301498095
##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/io/AvroIOTest.java
##########
@@ -1230,21 +1349,43 @@ public void testDynamicDestinationsWithNumShards()
throws Exception {
@Category(NeedsRunner.class)
public void testDynamicDestinationsViaSinkRunnerDeterminedSharding()
throws Exception {
testDynamicDestinationsUnwindowedWithSharding(
- WriteMethod.AVROIO_SINK, Sharding.RUNNER_DETERMINED);
+ WriteMethod.AVROIO_SINK_WITH_SCHEMA, Sharding.RUNNER_DETERMINED);
Review comment:
All of the tests going to `testDynamicDestinationsUnwindowedWithSharding`
exercise the non-specific ("GenericRecord") implementation. There is no
specific record ( or `Class<...>`) associated with the schemas in this test.
In the past `WriteMethod` flipped between `write()` and `sink`, now it
distinguishes between the different sink methods explicitly (hopefully making
the test more readable!).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 273941)
Time Spent: 3h (was: 2h 50m)
> Add AvroIO.sink for IndexedRecord (FileIO compatible)
> -----------------------------------------------------
>
> Key: BEAM-6480
> URL: https://issues.apache.org/jira/browse/BEAM-6480
> Project: Beam
> Issue Type: New Feature
> Components: io-java-avro
> Affects Versions: 2.9.0
> Reporter: Romain Manni-Bucau
> Assignee: Ryan Skraba
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> More generally for sink there is no need to create a mapper API since the
> previous PTransform can always map in a format the sink support so any sink
> can assume the format is right.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
