[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=274235&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274235
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/19 17:26
Start Date: 09/Jul/19 17:26
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #9020: [BEAM-4775] Support
returning metrics from job service
URL: https://github.com/apache/beam/pull/9020#issuecomment-509732880
A PR draft because I wanted to have the tests run and I'm currently
experiencing a problem when trying to test the solution. Nevertheless, any
comments and help appreciated - it will speed up my work. :)
When Running a pipeline using `portable_runner.py` and Flink, I get the
following error:
```
Error
Traceback (most recent call last):
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 360, in run
self.tearDown()
File
"/Users/lukasz/Projects/apache-beam/beam/sdks/python/apache_beam/testing/load_tests/load_test.py",
line 72, in tearDown
self.metrics_monitor.publish_metrics(result)
File
"/Users/lukasz/Projects/apache-beam/beam/sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py",
line 96, in publish_metrics
metrics = result.metrics().query()
File
"/Users/lukasz/Projects/apache-beam/beam/sdks/python/apache_beam/runners/portability/portable_runner.py",
line 415, in metrics
beam_job_api_pb2.GetJobMetricsRequest(job_id=self._job_id))
File
"/Users/lukasz/IdeaProjects/beam/venv/lib/python2.7/site-packages/grpc/_channel.py",
line 565, in __call__
return _end_unary_response_blocking(state, call, False, None)
File
"/Users/lukasz/IdeaProjects/beam/venv/lib/python2.7/site-packages/grpc/_channel.py",
line 467, in _end_unary_response_blocking
raise _Rendezvous(state, None, None, deadline)
_Rendezvous: <_Rendezvous of RPC that terminated with:
status = StatusCode.UNIMPLEMENTED
details = "Method
org.apache.beam.model.job_management.v1.JobService/GetJobMetrics is
unimplemented"
debug_error_string =
"{"created":"@1562692096.603684000","description":"Error received from peer
ipv6:[::1]:49810","file":"src/core/lib/surface/call.cc","file_line":1052,"grpc_message":"Method
org.apache.beam.model.job_management.v1.JobService/GetJobMetrics is
unimplemented","grpc_status":12}"
>Error
Traceback (most recent call last):
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 360, in run
self.tearDown()
File
"/Users/lukasz/Projects/apache-beam/beam/sdks/python/apache_beam/testing/load_tests/load_test.py",
line 72, in tearDown
self.metrics_monitor.publish_metrics(result)
File
"/Users/lukasz/Projects/apache-beam/beam/sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py",
line 96, in publish_metrics
metrics = result.metrics().query()
File
"/Users/lukasz/Projects/apache-beam/beam/sdks/python/apache_beam/runners/portability/portable_runner.py",
line 415, in metrics
beam_job_api_pb2.GetJobMetricsRequest(job_id=self._job_id))
File
"/Users/lukasz/IdeaProjects/beam/venv/lib/python2.7/site-packages/grpc/_channel.py",
line 565, in __call__
return _end_unary_response_blocking(state, call, False, None)
File
"/Users/lukasz/IdeaProjects/beam/venv/lib/python2.7/site-packages/grpc/_channel.py",
line 467, in _end_unary_response_blocking
raise _Rendezvous(state, None, None, deadline)
_Rendezvous: <_Rendezvous of RPC that terminated with:
status = StatusCode.UNIMPLEMENTED
details = "Method
org.apache.beam.model.job_management.v1.JobService/GetJobMetrics is
unimplemented"
debug_error_string =
"{"created":"@1562692096.603684000","description":"Error received from peer
ipv6:[::1]:49810","file":"src/core/lib/surface/call.cc","file_line":1052,"grpc_message":"Method
org.apache.beam.model.job_management.v1.JobService/GetJobMetrics is
unimplemented","grpc_status":12}"
>
```
I tried rebuilding the model/* and the java-fn-execution modules but it
didn't help. Will dig more tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 274235)
Time Spent: 41.5h (was: 41h 20m)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Lukasz Gajowy
> Priority: Major
> Time Spent: 41.5h
> Remaining Estimate: 0h
>
> Design doc: [https://s.apache.org/get-metrics-api].
> Further discussion is ongoing on [this
> doc|https://docs.google.com/document/d/1m83TsFvJbOlcLfXVXprQm1B7vUakhbLZMzuRrOHWnTg/edit?ts=5c826bb4#heading=h.faqan9rjc6dm].
> We want to report job metrics back to the portability harness from the runner
> harness, for displaying to users.
> h1. Relevant PRs in flight:
> h2. Ready for Review:
> * [#8022|https://github.com/apache/beam/pull/8022]: correct the Job RPC
> protos from [#8018|https://github.com/apache/beam/pull/8018].
> h2. Iterating / Discussing:
> * [#7971|https://github.com/apache/beam/pull/7971]: Flink portable metrics:
> get ptransform from MonitoringInfo, not stage name
> ** this is a simpler, Flink-specific PR that is basically duplicated inside
> each of the following two, so may be worth trying to merge in first
> * #[7915|https://github.com/apache/beam/pull/7915]: use MonitoringInfo data
> model in Java SDK metrics
> * [#7868|https://github.com/apache/beam/pull/7868]: MonitoringInfo URN tweaks
> h2. Merged
> * [#8018|https://github.com/apache/beam/pull/8018]: add job metrics RPC
> protos
> * [#7867|https://github.com/apache/beam/pull/7867]: key MetricResult by a
> MetricKey
> * [#7938|https://github.com/apache/beam/pull/7938]: move MonitoringInfo
> protos to model/pipeline module
> * [#7883|https://github.com/apache/beam/pull/7883]: Add
> MetricQueryResults.allMetrics() helper
> * [#7866|https://github.com/apache/beam/pull/7866]: move function helpers
> from fn-harness to sdks/java/core
> * [#7890|https://github.com/apache/beam/pull/7890]: consolidate MetricResult
> implementations
> h2. Closed
> * [#7934|https://github.com/apache/beam/pull/7934]: job metrics RPC + SDK
> support
> * [#7876|https://github.com/apache/beam/pull/7876]: Clean up metric protos;
> support integer distributions, gauges
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)