[
https://issues.apache.org/jira/browse/BEAM-6740?focusedWorklogId=274335&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274335
]
ASF GitHub Bot logged work on BEAM-6740:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/19 20:12
Start Date: 09/Jul/19 20:12
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #8964: [BEAM-6740] Add
PTransformTranslator for Combine.Globally
URL: https://github.com/apache/beam/pull/8964#issuecomment-509789712
To be honest I was not even aware of these Combine components. This PR and
#9026 come from a regression that was accidentally introduced into the Spark
runner when we moved it into URN based translation. Spark runner specializes
both `Combine.Globally` and `Combine.GroupedValues` but both translations were
never called because there were not `PTransformTranslator`s associated for
both of them. So the goal of these PRs is first to fix that. However I am
curious on any extra feedback for things we can improve for the respective
cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 274335)
Time Spent: 5.5h (was: 5h 20m)
> Combine.Globally translation is never called
> --------------------------------------------
>
> Key: BEAM-6740
> URL: https://issues.apache.org/jira/browse/BEAM-6740
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Etienne Chauchot
> Assignee: Ismaël Mejía
> Priority: Major
> Labels: portability
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Beam translates Combine.Globally as a composite transform composed of:
> * Map that assigns Void keys
> * Combine.PerKey
> on spark: As Combine.Perkey uses a spark GBK inside it, the runner adds its
> own translation of Combine.Globally to avoid less performant GBK. This
> translation should be called in place of entering the composite transform
> translation.A pipeline like this:
> {code:java}
> PCollection<Integer> input = pipeline.apply(Create.of(1, 2, 3, 4, 5, 6, 7, 8,
> 9, 10));
> input.apply(
> Combine.globally(new IntegerCombineFn()));
> {code}
> {code:java}
> private static class IntegerCombineFn extends Combine.CombineFn<Integer,
> Integer, Integer> {
> @Override
> public Integer createAccumulator() {
> return 0;
> }
> @Override
> public Integer addInput(Integer accumulator, Integer input) {
> return accumulator + input;
> }
> @Override
> public Integer mergeAccumulators(Iterable<Integer> accumulators) {
> Integer result = 0;
> for (Integer value : accumulators) {
> result += value;
> }
> return result;
> }
> @Override
> public Integer extractOutput(Integer accumulator) {
> return accumulator;
> }
> }
> {code}
> is translated as the above composite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
