[
https://issues.apache.org/jira/browse/BEAM-7711?focusedWorklogId=274572&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274572
]
ASF GitHub Bot logged work on BEAM-7711:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/19 00:43
Start Date: 10/Jul/19 00:43
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #8994: [BEAM-7711]
Add DATETIME as a logical type in BeamSQL
URL: https://github.com/apache/beam/pull/8994#discussion_r301847271
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/CalciteUtils.java
##########
@@ -154,6 +163,7 @@ public static boolean isStringType(FieldType fieldType) {
.put(TIME_WITH_LOCAL_TZ, SqlTypeName.TIME_WITH_LOCAL_TIME_ZONE)
.put(TIMESTAMP, SqlTypeName.TIMESTAMP)
.put(TIMESTAMP_WITH_LOCAL_TZ,
SqlTypeName.TIMESTAMP_WITH_LOCAL_TIME_ZONE)
+ .put(DATETIME, SqlTypeName.TIMESTAMP)
Review comment:
For sure ideally the change should happen in Calcite (add the corresponding
type for example).
As a workaround, what I was really thinking is use
`TIMESTAMP_WITH_LOCAL_TIME_ZONE` for `DateTime` and we actually disable
`TIMESTAMP_WITH_LOCAL_TIME_ZONE` as a type for BeamSQL right now. So there is a
one-one mapping between `DateTime` and `TIMESTAMP_WITH_LOCAL_TIME_ZONE` If you
think this is not acceptable, then I guess we have to make a change to Calcite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 274572)
Time Spent: 1h 20m (was: 1h 10m)
> Support DATETIME as a logical type in BeamSQL
> ---------------------------------------------
>
> Key: BEAM-7711
> URL: https://issues.apache.org/jira/browse/BEAM-7711
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Rui Wang
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> DATETIME as a type represents a year, month, day, hour, minute, second, and
> subsecond(millis)
> it ranges from 0001-01-01 00:00:00 to 9999-12-31 23:59:59.999.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
