[
https://issues.apache.org/jira/browse/BEAM-4948?focusedWorklogId=275152&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-275152
]
ASF GitHub Bot logged work on BEAM-4948:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jul/19 03:40
Start Date: 11/Jul/19 03:40
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9038: [BEAM-4948,
BEAM-6267, BEAM-5559, BEAM-7289] Fix shading of vendored guava to exclude
classes from transitive dependencies which aren't needed at runtime
URL: https://github.com/apache/beam/pull/9038#discussion_r302352625
##########
File path: vendor/guava-26_0-jre/build.gradle
##########
@@ -29,6 +29,13 @@ vendorJava(
"com.google.common":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.common",
"com.google.thirdparty":
"org.apache.beam.vendor.guava.v26_0_jre.com.google.thirdparty",
],
+ exclusions: [
Review comment:
To upgrade our vendored usage of guava we have to create an updated version
of that artifact. We are currently using 20.0 and I checked in a previous PR
that would allow building a vendored version of 26.0-jre but Kenn correctly
pointed out that the artifact was incorrectly created due to it containing all
these additional classes from transitive dependencies so I have added these
exclusions to prevent these classes from appearing in the jar so I can work on
producing the next release candidate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 275152)
Time Spent: 1h 50m (was: 1h 40m)
> Beam Dependency Update Request: com.google.guava
> ------------------------------------------------
>
> Key: BEAM-4948
> URL: https://issues.apache.org/jira/browse/BEAM-4948
> Project: Beam
> Issue Type: Bug
> Components: dependencies
> Reporter: Beam JIRA Bot
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> 2018-07-25 20:28:03.628639
> Please review and upgrade the com.google.guava to the latest version
> None
>
> cc:
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
