[
https://issues.apache.org/jira/browse/BEAM-7437?focusedWorklogId=275561&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-275561
]
ASF GitHub Bot logged work on BEAM-7437:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/19 00:11
Start Date: 12/Jul/19 00:11
Worklog Time Spent: 10m
Work Description: udim commented on pull request #9044: [BEAM-7437] Raise
RuntimeError for PY2 in BigqueryFullResultStreamingMatcher
URL: https://github.com/apache/beam/pull/9044#discussion_r302787083
##########
File path: sdks/python/apache_beam/io/gcp/tests/bigquery_matcher.py
##########
@@ -192,7 +193,10 @@ def _get_query_result(self, bigquery_client):
if len(response) >= len(self.expected_data):
return response
time.sleep(1)
- raise TimeoutError('Timeout exceeded for matcher.')
+ if six.PY3:
Review comment:
We've decided against using `six` in the Beam codebase. You can check for
Python version using this code instead:
```suggestion
if sys.version_info >= (3,):
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 275561)
Time Spent: 6h 40m (was: 6.5h)
> Integration Test for BQ streaming inserts for streaming pipelines
> -----------------------------------------------------------------
>
> Key: BEAM-7437
> URL: https://issues.apache.org/jira/browse/BEAM-7437
> Project: Beam
> Issue Type: Test
> Components: io-python-gcp
> Affects Versions: 2.12.0
> Reporter: Tanay Tummalapalli
> Assignee: Tanay Tummalapalli
> Priority: Minor
> Labels: test
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> Integration Test for BigQuery Sink using Streaming Inserts for streaming
> pipelines.
> Integration tests currently exist for batch pipelines, it can also be added
> for streaming pipelines using TestStream. This will be a precursor to the
> failing integration test to be added for [BEAM-6611|
> https://issues.apache.org/jira/browse/BEAM-6611].
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
