[
https://issues.apache.org/jira/browse/BEAM-7668?focusedWorklogId=276755&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276755
]
ASF GitHub Bot logged work on BEAM-7668:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/19 14:32
Start Date: 15/Jul/19 14:32
Worklog Time Spent: 10m
Work Description: lostluck commented on issue #8977: [BEAM-7668] Add
GetPipeline method to gRPC JobService
URL: https://github.com/apache/beam/pull/8977#issuecomment-511427539
Nit: beam isn't yet using Go Modules. Go calls the unit of dependency
packages.
Conventionally, the go tooling doesn't do generation at compile time. The
main reason is there are ample tools to do that externally to the go tooling
(eg. Gradle, bazel, make, etc) that any end user can set that up should they
desire it.
Further, generated code is for the package authors, not the end user, and
should be commitable.
The impedance mismatch is that beam is a mid-level library. So the proto
code needs to be generated with `go generate`, and committed, because of the
above conventions. Eg. Beam devs may use Gradle, but end go programmers will
probably not, not can we mandate it.
We haven't been rigorous about what version of protoc and the go proto
packages to use, hence the piles of differences. As long as the external proto
API doesn't change in a backwards incompatible way and the integration tests
against flink and spark work, I'm not bothered about what the generated code
looks like until we can ensure people can use consistent versions to generate
the code, with Go Modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 276755)
Time Spent: 4h 20m (was: 4h 10m)
> Add ability to query a pipeline from a gRPC JobService
> ------------------------------------------------------
>
> Key: BEAM-7668
> URL: https://issues.apache.org/jira/browse/BEAM-7668
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Labels: portability
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> As a developer I want to query the pipeline definition of jobs that have
> already been submitted to the Job Service, so that I can write a UI to view
> and monitor Beam pipelines via the portability model.
>
> PR is coming soon!
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
