[ 
https://issues.apache.org/jira/browse/BEAM-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885697#comment-16885697
 ] 

Pablo Estrada edited comment on BEAM-7674 at 7/15/19 11:30 PM:
---------------------------------------------------------------

Sorry for the delay to answer. That test should be a pure streaming test (see 
how it uses TestStream).
Edit: ugh, well, that's embarrassing: I see you've added it. Thanks guys : )


was (Author: pabloem):
Sorry for the delay to answer. That test should be a pure streaming test (see 
how it uses TestStream).

> Define streaming ITs tests for direct runner in consistent way in Python 2 
> and  Python 3 suites.
> ------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-7674
>                 URL: https://issues.apache.org/jira/browse/BEAM-7674
>             Project: Beam
>          Issue Type: Improvement
>          Components: testing
>            Reporter: Valentyn Tymofieiev
>            Assignee: Juta Staes
>            Priority: Major
>
> Currently in Python 2 direct runner test suite  some tests run in streaming 
> mode:
> https://github.com/apache/beam/blob/fbd1f4cf7118c7b2fb4e3a4cf46646e98f3e3b8d/sdks/python/build.gradle#L130
> However in Python 3, we run both Batch and Streaming direct runner tests in 
> Batch mode: 
> https://github.com/apache/beam/blob/fbd1f4cf7118c7b2fb4e3a4cf46646e98f3e3b8d/sdks/python/test-suites/direct/py35/build.gradle#L32
> We should check whether we need to explicitly separate the tests into batch 
> and streaming and define all directrunner suites consistently.
> cc: [~Juta]



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to