[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=278154&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-278154
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/19 10:52
Start Date: 17/Jul/19 10:52
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #9020: [BEAM-4775] Support
returning metrics from job service
URL: https://github.com/apache/beam/pull/9020#issuecomment-512204574
@ibzib thanks! Posted the fixes.
> My understanding is that most of the remaining work is on the SDK side,
and that things should be pretty trivial on the runner side as we already have
getMonitoringInfos [1]. Is that correct / could you elaborate on the next steps?
This is exactly my idea and intent behind this pr. I first wanted to enable
reading the MIs easily. `getMonitoringInfos()` is the method that can be used
for that indeed.
The next steps are:
1. Read metrics in `FlinkPortableRunnerResult` class. This is trivial - in
fact, I can quickly code that and post an additional commit to this PR.
2. Convert on the sdk side (python) to MetricsResults - this is the harder
thing to do, but the assumption I have now is that once we have all
MonitoringInfos on the sdk side, we're able to do the conversion there.
For now, I decided to implement the collection only for Flink (1) to have
something working. After we have this we can implement the `portableMetrics()`
methods for particular runners easily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 278154)
Time Spent: 44h 40m (was: 44.5h)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Lukasz Gajowy
> Priority: Major
> Time Spent: 44h 40m
> Remaining Estimate: 0h
>
> Design doc: [https://s.apache.org/get-metrics-api].
> Further discussion is ongoing on [this
> doc|https://docs.google.com/document/d/1m83TsFvJbOlcLfXVXprQm1B7vUakhbLZMzuRrOHWnTg/edit?ts=5c826bb4#heading=h.faqan9rjc6dm].
> We want to report job metrics back to the portability harness from the runner
> harness, for displaying to users.
> h1. Relevant PRs in flight:
> h2. Ready for Review:
> * [#8022|https://github.com/apache/beam/pull/8022]: correct the Job RPC
> protos from [#8018|https://github.com/apache/beam/pull/8018].
> h2. Iterating / Discussing:
> * [#7971|https://github.com/apache/beam/pull/7971]: Flink portable metrics:
> get ptransform from MonitoringInfo, not stage name
> ** this is a simpler, Flink-specific PR that is basically duplicated inside
> each of the following two, so may be worth trying to merge in first
> * #[7915|https://github.com/apache/beam/pull/7915]: use MonitoringInfo data
> model in Java SDK metrics
> * [#7868|https://github.com/apache/beam/pull/7868]: MonitoringInfo URN tweaks
> h2. Merged
> * [#8018|https://github.com/apache/beam/pull/8018]: add job metrics RPC
> protos
> * [#7867|https://github.com/apache/beam/pull/7867]: key MetricResult by a
> MetricKey
> * [#7938|https://github.com/apache/beam/pull/7938]: move MonitoringInfo
> protos to model/pipeline module
> * [#7883|https://github.com/apache/beam/pull/7883]: Add
> MetricQueryResults.allMetrics() helper
> * [#7866|https://github.com/apache/beam/pull/7866]: move function helpers
> from fn-harness to sdks/java/core
> * [#7890|https://github.com/apache/beam/pull/7890]: consolidate MetricResult
> implementations
> h2. Closed
> * [#7934|https://github.com/apache/beam/pull/7934]: job metrics RPC + SDK
> support
> * [#7876|https://github.com/apache/beam/pull/7876]: Clean up metric protos;
> support integer distributions, gauges
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
