[
https://issues.apache.org/jira/browse/BEAM-7262?focusedWorklogId=278341&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-278341
]
ASF GitHub Bot logged work on BEAM-7262:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/19 17:37
Start Date: 17/Jul/19 17:37
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #9065:
[BEAM-7262] 2.7.1 LTS backport: normalize httplib2.Http initialization and usage
URL: https://github.com/apache/beam/pull/9065#discussion_r304557345
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -422,6 +423,8 @@ def __init__(self, options):
credentials = None
else:
credentials = get_service_credentials()
+
+ http_client = get_new_http()
Review comment:
pylint says this is unused, which appears true. I think its a bad backport.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 278341)
Time Spent: 40m (was: 0.5h)
> LTS backport: normalize httplib2.Http initialization and usage
> --------------------------------------------------------------
>
> Key: BEAM-7262
> URL: https://issues.apache.org/jira/browse/BEAM-7262
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Kenneth Knowles
> Priority: Major
> Fix For: 2.7.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Ideally solve both issues below in one PR, but issue 1 has priority as it can
> halt a pipeline.
> Issue 1:
> Datastore client (and other httplib2-based clients for GCS, Dataflow,
> BigQuery, etc.) doesn't set a socket timeout.
> This can cause _flush_batch() in datastoreio.py to block forever waiting for
> a response.
> This issue is very similar to https://issues.apache.org/jira/browse/BEAM-5915
> and the solution should be similar.
> Issue 2:
> Standardize use of proxy environment settings, as in gcsio:
> https://github.com/apache/beam/blob/8d3389df78aa2e0a0de06b7c5743ca3530dec4ac/sdks/python/apache_beam/io/gcp/gcsio.py#L136
> Issue for proxy settings: https://issues.apache.org/jira/browse/BEAM-3184
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
