[ 
https://issues.apache.org/jira/browse/BEAM-4948?focusedWorklogId=278585&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-278585
 ]

ASF GitHub Bot logged work on BEAM-4948:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jul/19 23:27
            Start Date: 17/Jul/19 23:27
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on issue #8899: [BEAM-4948, 
BEAM-6267, BEAM-5559, BEAM-7289] Update the version of guava to 26.0-jre for 
all our vendored artifacts containing guava
URL: https://github.com/apache/beam/pull/8899#issuecomment-512605643
 
 
   The issue is that Guava migrated to the checkerframework `@Nullable` instead 
of the javax version which made spotbugs perform its nullness checks. For 
example, the Guava Function class has the parameter marked as `@Nullable` which 
means that the function must correctly handle null inputs which some of our 
previous Function implementations were not. So I could either update them to 
handle null inputs or mark them as `@Nonnull`. The issue with the latter is 
that we are now narrowing the definition from a Function that took nullable 
input to one that didn't which required a different FB suppression.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 278585)
    Time Spent: 4h 10m  (was: 4h)

> Beam Dependency Update Request: com.google.guava
> ------------------------------------------------
>
>                 Key: BEAM-4948
>                 URL: https://issues.apache.org/jira/browse/BEAM-4948
>             Project: Beam
>          Issue Type: Bug
>          Components: dependencies
>            Reporter: Beam JIRA Bot
>            Priority: Major
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> 2018-07-25 20:28:03.628639
>         Please review and upgrade the com.google.guava to the latest version 
> None 
>  
>         cc: 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to