[
https://issues.apache.org/jira/browse/BEAM-7680?focusedWorklogId=278900&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-278900
]
ASF GitHub Bot logged work on BEAM-7680:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/19 11:21
Start Date: 18/Jul/19 11:21
Worklog Time Spent: 10m
Work Description: kkucharc commented on pull request #9049: [BEAM-7680]
Removed flaky assertion and separated unit tests in synthetic source test
URL: https://github.com/apache/beam/pull/9049#discussion_r304863914
##########
File path: sdks/python/apache_beam/testing/synthetic_pipeline_test.py
##########
@@ -57,29 +57,39 @@ class SyntheticPipelineTest(unittest.TestCase):
# pylint: disable=expression-not-assigned
- def test_synthetic_step(self):
- start = time.time()
+ def test_count_elements_after_synthetic_step(self):
Review comment:
To be honest I am not really sure if the numbers here are essential, but
more if the count is just correct (that's why I suggested the original name). I
can agree, if there will be similar test that will also return 100 elements, it
would have to be distinguished somehow. So what do you think about compromise
where we focus what is tested and we skip numbers, because those aren't
important in this case? By the rule `test[Feature being tested]` we can have
something like: `test_synthetic_step_multiplies_output_elements_count`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 278900)
Time Spent: 2h 50m (was: 2h 40m)
> synthetic_pipeline_test.py flaky
> --------------------------------
>
> Key: BEAM-7680
> URL: https://issues.apache.org/jira/browse/BEAM-7680
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Udi Meiri
> Assignee: Kasia Kucharczyk
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> {code:java}
> 11:51:43 FAIL: testSyntheticSDFStep
> (apache_beam.testing.synthetic_pipeline_test.SyntheticPipelineTest)
> 11:51:43
> ----------------------------------------------------------------------
> 11:51:43 Traceback (most recent call last):
> 11:51:43 File
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Cron/src/sdks/python/test-suites/tox/py35/build/srcs/sdks/python/apache_beam/testing/synthetic_pipeline_test.py",
> line 82, in testSyntheticSDFStep
> 11:51:43 self.assertTrue(0.5 <= elapsed <= 3, elapsed)
> 11:51:43 AssertionError: False is not true : 3.659700632095337{code}
> [https://builds.apache.org/job/beam_PreCommit_Python_Cron/1502/consoleFull]
>
> Two flaky TODOs:
> [https://github.com/apache/beam/blob/b79f24ced1c8519c29443ea7109c59ad18be2ebe/sdks/python/apache_beam/testing/synthetic_pipeline_test.py#L69-L82]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
