[
https://issues.apache.org/jira/browse/BEAM-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888760#comment-16888760
]
Salman Raza commented on BEAM-6858:
-----------------------------------
[~reuvenlax]
We were looking in this jira and as per description it has following two parts:
1. Add annotation for side input
Now two things here how the values are going to be passed in the
parameters of side inputs? do we need to implement something similar like
StateId? (implementation is different for @Element and @StateId)
2. Add those side inputs in ParDo
ParDo.java has method withSideInputs, understanding is we need to use
this existing method and side inputs can be get from DoFnSignatures.
3. Since it can be any object, then do you want this to verify in ParDo?
Can you please clear the questions and give your suggestions on it?
> Support side inputs injected into a DoFn
> ----------------------------------------
>
> Key: BEAM-6858
> URL: https://issues.apache.org/jira/browse/BEAM-6858
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Shehzaad Nakhoda
> Priority: Major
>
> Beam currently supports injecting main inputs into a DoFn process method. A
> user can write the following:
> @ProcessElement public void process(@Element InputT element)
> And Beam will (using ByteBuddy code generation) inject the input element into
> the process method.
> We would like to also support the same for side inputs. For example:
> @ProcessElement public void process(@Element InputT element,
> @SideInput("tag1") String input1, @SideInput("tag2") Integer input2)
> This requires the existing process-method analysis framework to capture these
> side inputs. The ParDo code would have to verify the type of the side input
> and include them in the list of side inputs. This would also eliminate the
> need for the user to explicitly call withSideInputs on the ParDo.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
