[
https://issues.apache.org/jira/browse/BEAM-4181?focusedWorklogId=281054&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-281054
]
ASF GitHub Bot logged work on BEAM-4181:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/19 14:10
Start Date: 23/Jul/19 14:10
Worklog Time Spent: 10m
Work Description: RyanSkraba commented on issue #9088: [BEAM-4181] Add
ReadFiles transform to TfRecordIO
URL: https://github.com/apache/beam/pull/9088#issuecomment-514226866
Heyo -- just a quick question on reflection. Should I refactor the existing
`Read`/`read()` transform to use this proposed `ReadFiles`/`readFiles()` ? I
see that some other FileIOs do this.
If yes, how do you feel about the `read().withHintMatchesManyFiles()` to
switch between the original `read()` and new `readFiles()` technique? I see
TextIO and AvroIO do this, but I'm not sure whether this is "best practices".
It's weird to me to refactor the original `read()` to require a "hint" to
use the new implementation, when the new implement is ... just right there
below it! WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 281054)
Time Spent: 20m (was: 10m)
> Add ReadFiles transform for TfRecordIO
> --------------------------------------
>
> Key: BEAM-4181
> URL: https://issues.apache.org/jira/browse/BEAM-4181
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Chamikara Jayalath
> Assignee: Ryan Skraba
> Priority: Major
> Fix For: 2.15.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This will be needed for reading TFRecord file globs that expand into a huge
> number of files.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
