[
https://issues.apache.org/jira/browse/BEAM-3645?focusedWorklogId=281093&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-281093
]
ASF GitHub Bot logged work on BEAM-3645:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/19 15:20
Start Date: 23/Jul/19 15:20
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #8979: [BEAM-3645]
add multiplexing for python FnApiRunner
URL: https://github.com/apache/beam/pull/8979#discussion_r306370972
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -1142,17 +1230,15 @@ def __init__(self, state, provision_info):
self.data_server.start()
self.control_server.start()
- def data_api_service_descriptor(self):
- return endpoints_pb2.ApiServiceDescriptor(
- url='localhost:%s' % self.data_port)
-
- def state_api_service_descriptor(self):
- return endpoints_pb2.ApiServiceDescriptor(
- url='localhost:%s' % self.state_port)
+ @classmethod
+ def get_instance(cls, state, provision_info):
Review comment:
This method and `release_instance` should do the reference counting and
decision whether to "actually" close and deallocate the server, not the
callers. That keeps it more local and easier to reason about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 281093)
Time Spent: 28h 40m (was: 28.5h)
> Support multi-process execution on the FnApiRunner
> --------------------------------------------------
>
> Key: BEAM-3645
> URL: https://issues.apache.org/jira/browse/BEAM-3645
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.2.0, 2.3.0
> Reporter: Charles Chen
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.15.0
>
> Time Spent: 28h 40m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/BEAM-3644 gave us a 15x performance
> gain over the previous DirectRunner. We can do even better in multi-core
> environments by supporting multi-process execution in the FnApiRunner, to
> scale past Python GIL limitations.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
