[
https://issues.apache.org/jira/browse/BEAM-7797?focusedWorklogId=281415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-281415
]
ASF GitHub Bot logged work on BEAM-7797:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/19 00:48
Start Date: 24/Jul/19 00:48
Worklog Time Spent: 10m
Work Description: aaltay commented on issue #9128: [BEAM-7797] Move
upload_graph handling logic before template generation.
URL: https://github.com/apache/beam/pull/9128#issuecomment-514435335
I see this error:
(see:
https://builds.apache.org/job/beam_PreCommit_Spotless_Commit/4528/console)
13:46:31 * What went wrong:
13:46:31 Execution failed for task
':runners:google-cloud-dataflow-java:spotlessJava'.
13:46:31 > The following files had format violations:
13:46:31
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
13:46:31 @@ -1309,8 +1309,8 @@
13:46:31
13:46:31 ··/**
13:46:31
···*·Tests·that·the·{@link·DataflowRunner}·with·{@code·--templateLocation}·returns·normally·when·the
13:46:31
-···*·runner·is·successfully·run·with·upload_graph·experiment·turned·on.
13:46:31
-···*·The·result·template·should·not·contain·raw·steps·and·stepsLocation·file·should·be·set.
13:46:31
+···*·runner·is·successfully·run·with·upload_graph·experiment·turned·on.·The·result·template·should
13:46:31
+···*·not·contain·raw·steps·and·stepsLocation·file·should·be·set.
13:46:31 ···*/
13:46:31 ··@Test
13:46:31
··public·void·testTemplateRunnerWithUploadGraph()·throws·Exception·{
13:46:31 Run 'gradlew spotlessApply' to fix these violations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 281415)
Time Spent: 40m (was: 0.5h)
Remaining Estimate: 47h 20m (was: 47.5h)
> DataflowRunner's upload_graph feature doesn't reduce template file size
> -----------------------------------------------------------------------
>
> Key: BEAM-7797
> URL: https://issues.apache.org/jira/browse/BEAM-7797
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Yunqing Zhou
> Assignee: Yunqing Zhou
> Priority: Minor
> Fix For: 2.15.0
>
> Original Estimate: 48h
> Time Spent: 40m
> Remaining Estimate: 47h 20m
>
> Dataflow Runner has a feature to save job graph separately, reducing the size
> of the request to Dataflow API.
> Since templates are simply dumps of requests to the API, sizes of template
> files should be reduced as well.
>
> However, the logic to remove parts from the request happened after template
> file generation.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
