[ 
https://issues.apache.org/jira/browse/BEAM-7739?focusedWorklogId=282014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-282014
 ]

ASF GitHub Bot logged work on BEAM-7739:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Jul/19 15:11
            Start Date: 24/Jul/19 15:11
    Worklog Time Spent: 10m 
      Work Description: rakeshcusat commented on issue #9067: [BEAM-7739] 
Implement ReadModifyWriteState in Python SDK
URL: https://github.com/apache/beam/pull/9067#issuecomment-514669305
 
 
   > > @robertwb can you confirm that we also need to introduce 
ReadModifyWriteState in the proto definition?
   > 
   > Or simply rename ValueStateSpec in the proto. (These protos are still in a 
state they can be modified.)
   
   I just want to make sure I understand it correctly, In case I rename this, I 
also need to rename in Java SDK as well because it is used there as well, 
right? 
   I didn't see any reference in Go SDK other then the auto-generated code so I 
am assuming it is not yet implemented in Go SDK
   
   I will rename the spec to be consistent and avoid any confusion in future.
   
   Edit: 
   on second thought I am concerned about this line 
https://github.com/apache/beam/blob/57969314109ad1d58593f06d8c66f20020a7ad81/model/pipeline/src/main/proto/beam_runner_api.proto#L414
 if I would rename this proto. Wouldn't it cause proto to complain that we have 
changed the type and cause some incompatibility problem?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 282014)
    Time Spent: 2h 20m  (was: 2h 10m)

> Add ValueState in Python sdk
> ----------------------------
>
>                 Key: BEAM-7739
>                 URL: https://issues.apache.org/jira/browse/BEAM-7739
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-py-core
>            Reporter: Rakesh Kumar
>            Assignee: Rakesh Kumar
>            Priority: Major
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Currently ValueState is missing from Python Sdks but it is existing in Java 
> sdks. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to