[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=282355&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-282355
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/19 23:34
Start Date: 24/Jul/19 23:34
Worklog Time Spent: 10m
Work Description: chadrik commented on issue #9056: [BEAM-7746] Add
python type hints
URL: https://github.com/apache/beam/pull/9056#issuecomment-514837470
I left a note on that PR about `transforms.core` not being converted yet.
Separate question:
Are the following two examples functionally equivalent in beam?
```python
coll = pipe | core.Map(lambda _, x: x.do_stuff(), self.thing)
```
```python
coll = pipe | core.Map(lambda _, x=self.thing: x.do_stuff())
```
I would hope that they are, but I could see there being some difference in
how the transforms get serialized.
The reason I ask is that it's going to be tricky to deal with the shifting
signatures of methods like `DoFn.process()` and `PTransform.expand()`, since
mypy can be [a bit picky about
this](https://github.com/python/mypy/issues/1237). I'm trying to work out some
strategies for addressing this, and this is one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 282355)
Time Spent: 5.5h (was: 5h 20m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
