[
https://issues.apache.org/jira/browse/BEAM-3645?focusedWorklogId=282597&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-282597
]
ASF GitHub Bot logged work on BEAM-3645:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/19 10:06
Start Date: 25/Jul/19 10:06
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #8979: [BEAM-3645]
add multiplexing for python FnApiRunner
URL: https://github.com/apache/beam/pull/8979#discussion_r307180997
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -937,14 +987,15 @@ def close(self):
class WorkerHandler(object):
- """Controller for a worker.
+ """worker_handler for a worker.
It provides utilities to start / stop the worker, provision any resources for
it, as well as provide descriptors for the data, state and logging APIs for
it.
"""
_registered_environments = {}
+ _worker_id = -1
Review comment:
I think the functionality here is OK, but the naming makes things hard to
follow. You have a class-level `_worker_id` and a instance-level `worker_id`
and a method `get_worker_id` that returns not the worker id for this
WorkerHandler, but a newly allocated worker id.
I would rename `_worker_id` to something like `_worker_id_counter`, and
`get_worker_id` to `create_unique_worker_id` or similar (and make it a
`@classmethod`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 282597)
Time Spent: 31h 40m (was: 31.5h)
> Support multi-process execution on the FnApiRunner
> --------------------------------------------------
>
> Key: BEAM-3645
> URL: https://issues.apache.org/jira/browse/BEAM-3645
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.2.0, 2.3.0
> Reporter: Charles Chen
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.15.0
>
> Time Spent: 31h 40m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/BEAM-3644 gave us a 15x performance
> gain over the previous DirectRunner. We can do even better in multi-core
> environments by supporting multi-process execution in the FnApiRunner, to
> scale past Python GIL limitations.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
