[
https://issues.apache.org/jira/browse/BEAM-7814?focusedWorklogId=282977&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-282977
]
ASF GitHub Bot logged work on BEAM-7814:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/19 22:56
Start Date: 25/Jul/19 22:56
Worklog Time Spent: 10m
Work Description: udim commented on issue #9154: [BEAM-7814] Make
BigqueryMatcher wait for results.
URL: https://github.com/apache/beam/pull/9154#issuecomment-515244086
I have a bug or two:
```
14:09:37
======================================================================
14:09:37 ERROR: test__get_query_result_timeout
(apache_beam.io.gcp.tests.bigquery_matcher_test.BigqueryFullResultStreamingMatcher)
14:09:37
----------------------------------------------------------------------
14:09:37 Traceback (most recent call last):
14:09:37 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/target/.tox-py37-gcp/py37-gcp/lib/python3.7/site-packages/mock/mock.py",
line 1305, in patched
14:09:37 return func(*args, **keywargs)
14:09:37 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/apache_beam/io/gcp/tests/bigquery_matcher_test.py",
line 132, in test__get_query_result_timeout
14:09:37 matcher._get_query_result(None)
14:09:37 TypeError: _get_query_result() takes 1 positional argument but 2
were given
14:09:37
14:09:37
======================================================================
14:09:37 ERROR: test_bigquery_matcher_success
(apache_beam.io.gcp.tests.bigquery_matcher_test.BigqueryMatcherTest)
14:09:37
----------------------------------------------------------------------
14:09:37 Traceback (most recent call last):
14:09:37 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/target/.tox-py37-gcp/py37-gcp/lib/python3.7/site-packages/mock/mock.py",
line 1305, in patched
14:09:37 return func(*args, **keywargs)
14:09:37 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/apache_beam/io/gcp/tests/bigquery_matcher_test.py",
line 65, in test_bigquery_matcher_success
14:09:37 hc_assert_that(self._mock_result, matcher)
14:09:37 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/target/.tox-py37-gcp/py37-gcp/lib/python3.7/site-packages/hamcrest/core/assert_that.py",
line 43, in assert_that
14:09:37 _assert_match(actual=arg1, matcher=arg2, reason=arg3)
14:09:37 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/target/.tox-py37-gcp/py37-gcp/lib/python3.7/site-packages/hamcrest/core/assert_that.py",
line 49, in _assert_match
14:09:37 if not matcher.matches(actual):
14:09:37 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/target/.tox-py37-gcp/py37-gcp/lib/python3.7/site-packages/hamcrest/core/base_matcher.py",
line 28, in matches
14:09:37 match_result = self._matches(item)
14:09:37 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/apache_beam/io/gcp/tests/bigquery_matcher.py",
line 85, in _matches
14:09:37 response = self._query_with_retry()
14:09:37 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/apache_beam/utils/retry.py",
line 197, in wrapper
14:09:37 return fun(*args, **kwargs)
14:09:37 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/apache_beam/io/gcp/tests/bigquery_matcher.py",
line 102, in _query_with_retry
14:09:37 rows = query_job.result(timeout=60)
14:09:37 AttributeError: 'list' object has no attribute 'result'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 282977)
Time Spent: 2h 20m (was: 2h 10m)
> bigquery tests flaky with empty actual result values
> ----------------------------------------------------
>
> Key: BEAM-7814
> URL: https://issues.apache.org/jira/browse/BEAM-7814
> Project: Beam
> Issue Type: Bug
> Components: io-python-gcp
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Example failure:
> {code}
> 16:54:32
> ======================================================================
> 16:54:32 FAIL: test_big_query_write_new_types
> (apache_beam.io.gcp.bigquery_write_it_test.BigQueryWriteIntegrationTests)
> 16:54:32
> ----------------------------------------------------------------------
> 16:54:32 Traceback (most recent call last):
> 16:54:32 File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python35_PR/src/sdks/python/apache_beam/io/gcp/bigquery_write_it_test.py",
> line 229, in test_big_query_write_new_types
> 16:54:32 write_disposition=beam.io.BigQueryDisposition.WRITE_EMPTY))
> 16:54:32 File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python35_PR/src/sdks/python/apache_beam/pipeline.py",
> line 426, in __exit__
> 16:54:32 self.run().wait_until_finish()
> 16:54:32 File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python35_PR/src/sdks/python/apache_beam/pipeline.py",
> line 406, in run
> 16:54:32 self._options).run(False)
> 16:54:32 File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python35_PR/src/sdks/python/apache_beam/pipeline.py",
> line 419, in run
> 16:54:32 return self.runner.run_pipeline(self, self._options)
> 16:54:32 File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python35_PR/src/sdks/python/apache_beam/runners/direct/test_direct_runner.py",
> line 51, in run_pipeline
> 16:54:32 hc_assert_that(self.result, pickler.loads(on_success_matcher))
> 16:54:32 AssertionError:
> 16:54:32 Expected: (Expected data is [(0.33, Decimal('10'), b'\xab\xac',
> datetime.date(3000, 12, 31), datetime.time(23, 59, 59),
> datetime.datetime(2018, 12, 31, 12, 44, 31), datetime.datetime(2018, 12, 31,
> 12, 44, 31, 744957, tzinfo=<UTC>), 'POINT(30 10)'), (0.33, None, None, None,
> None, None, None, None), (None, Decimal('10'), None, None, None, None, None,
> None), (None, None, b'\xab\xac', None, None, None, None, None), (None, None,
> None, datetime.date(3000, 12, 31), None, None, None, None), (None, None,
> None, None, datetime.time(23, 59, 59), None, None, None), (None, None, None,
> None, None, datetime.datetime(2018, 12, 31, 12, 44, 31), None, None), (None,
> None, None, None, None, None, datetime.datetime(2018, 12, 31, 12, 44, 31,
> 744957, tzinfo=<UTC>), None), (None, None, None, None, None, None, None,
> 'POINT(30 10)')])
> 16:54:32 but:
> 16:54:32
> {code}
> I've managed to recreated this locally on my workstation. The issue seems to
> be incorrect usage of the BigQuery client library. PR forthcoming.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
