[
https://issues.apache.org/jira/browse/BEAM-3645?focusedWorklogId=283343&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283343
]
ASF GitHub Bot logged work on BEAM-3645:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/19 13:11
Start Date: 26/Jul/19 13:11
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #8979: [BEAM-3645]
add multiplexing for python FnApiRunner
URL: https://github.com/apache/beam/pull/8979#discussion_r307730447
##########
File path: sdks/python/apache_beam/runners/direct/direct_runner_test.py
##########
@@ -52,6 +54,15 @@ def test_waiting_on_result_stops_executor_threads(self):
post_test_threads = set(t.ident for t in threading.enumerate())
new_threads = post_test_threads - pre_test_threads
+ if len(new_threads) > 0:
+ for i in range(1,6):
+ logging.info('%s: Wait %s second(s) for thread(s) to close.' %
+ (runner, i))
+ time.sleep(i)
+ post_test_threads = set(t.ident for t in threading.enumerate())
+ new_threads = post_test_threads - pre_test_threads
+ if len(new_threads) == 0:
+ break
Review comment:
It be good to hunt down why we need to wait at all. What threads are these?
(To aid debugging, you might want to log each server that's created to ensure
it's shut down, and also make sure all threads that get started are created
with a meaningful name in their constructor).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 283343)
Time Spent: 32h 40m (was: 32.5h)
> Support multi-process execution on the FnApiRunner
> --------------------------------------------------
>
> Key: BEAM-3645
> URL: https://issues.apache.org/jira/browse/BEAM-3645
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.2.0, 2.3.0
> Reporter: Charles Chen
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.15.0
>
> Time Spent: 32h 40m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/BEAM-3644 gave us a 15x performance
> gain over the previous DirectRunner. We can do even better in multi-core
> environments by supporting multi-process execution in the FnApiRunner, to
> scale past Python GIL limitations.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
