[
https://issues.apache.org/jira/browse/BEAM-3645?focusedWorklogId=284532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-284532
]
ASF GitHub Bot logged work on BEAM-3645:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jul/19 20:47
Start Date: 29/Jul/19 20:47
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on issue #8979: [BEAM-3645] add
multiplexing for python FnApiRunner
URL: https://github.com/apache/beam/pull/8979#issuecomment-516155922
> The reason threads are not all killed immediately for direct runners for
10% of time is we are starting grpc servers and close it with direct runners.
Threads created for grpc servers at FnApi side are all closed immediately, but
it seems like a thread at grpc library is closed a little late. If confirmed
that if we don't start grpc servers for direct runner, then all thread are
closed immediately (sample size is 3,000.), so it would be resolved when we
don't create grpc servers for direct embedded runners.
>
> A side note about thread name is, we can add thread_name_prefix for
ThreadPoolExecutor, which is supported by concurrent lib from v3.6. However,
threads names created at grpc lib are in the default format. (Thread-N).
I noticed a problem with passing `thread_name_prefix` to
`ThreadPoolExecutor`. `thread_name_prefix` works fine with py27, py36 and py37,
but py35 throws out `got an unexpected keyword argument 'thread_name_prefix'`
error everywhere. If we want to pass thread_name_prefix`, we need to add a py
version check everywhere, can we skip it for now or it's still better to add it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 284532)
Time Spent: 34h 20m (was: 34h 10m)
> Support multi-process execution on the FnApiRunner
> --------------------------------------------------
>
> Key: BEAM-3645
> URL: https://issues.apache.org/jira/browse/BEAM-3645
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.2.0, 2.3.0
> Reporter: Charles Chen
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.15.0
>
> Time Spent: 34h 20m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/BEAM-3644 gave us a 15x performance
> gain over the previous DirectRunner. We can do even better in multi-core
> environments by supporting multi-process execution in the FnApiRunner, to
> scale past Python GIL limitations.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
