[
https://issues.apache.org/jira/browse/BEAM-7813?focusedWorklogId=285152&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-285152
]
ASF GitHub Bot logged work on BEAM-7813:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jul/19 18:40
Start Date: 30/Jul/19 18:40
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #9175:
[BEAM-7813] FileIO.write() doesn't fail when writing to invalid bucket
URL: https://github.com/apache/beam/pull/9175#discussion_r308880963
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java
##########
@@ -1318,7 +1318,7 @@ public void flush() throws IOException {
if (getFooter() != null) {
writer.println(getFooter());
}
- writer.close();
+ writer.flush();
Review comment:
Ah didn't realize that close() would swallow exceptions. Could you add a
comment here so that this does not get reverted. Also, please check if there
are other places in the JDK if we do that same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 285152)
Time Spent: 40m (was: 0.5h)
> FileIO.write() doesn't fail when writing to invalid bucket
> ----------------------------------------------------------
>
> Key: BEAM-7813
> URL: https://issues.apache.org/jira/browse/BEAM-7813
> Project: Beam
> Issue Type: Bug
> Components: io-java-files
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> FileIO.write() doesn't fail when writing to invalid bucket. It could happen
> that the job is successfully completed but output files are not generated.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
