[
https://issues.apache.org/jira/browse/BEAM-7854?focusedWorklogId=285309&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-285309
]
ASF GitHub Bot logged work on BEAM-7854:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jul/19 22:44
Start Date: 30/Jul/19 22:44
Worklog Time Spent: 10m
Work Description: tomerr90 commented on issue #9197: [BEAM-7854] Resolve
parent folder recursively in LocalFileSystem matc…
URL: https://github.com/apache/beam/pull/9197#issuecomment-516623699
R: @lukecwik @kennknowles @aaltay
Hey guys, would appreciate a review.
There is sort of a down-side to this fix, which is, if a user gives a glob
of a non existing directory like this: `/non_exisiting_dir`
We traverse the entire filesystem, the proper matches will still return
(None in this case) but it might take a lot of time for nothing.
Might need to think of a smarter resolver that checks if the string has glob
wildcards and if so reolves like it does in this PR, otherwise resolves the way
it was.
I dont really know how things work around here, so let me know what you
think :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 285309)
Time Spent: 20m (was: 10m)
> Reading files from local file system does not fully support glob
> ----------------------------------------------------------------
>
> Key: BEAM-7854
> URL: https://issues.apache.org/jira/browse/BEAM-7854
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Tomer Zeltzer
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Folder structure:
> {code:java}
> A
> B
> a=100
> data1
> file1.zst
> file2.zst
> a=999
> data2
> file6.zst
> a=397
> data3
> file7.zst{code}
>
> Glob:
>
> {code:java}
> /A/B/a=[0-9][0-9][0-9]/*/*{code}
> Code:
>
> {code:java}
> input.apply(Create.of(patterns))
> .apply("Matching patterns", FileIO.matchAll())
> .apply(FileIO.readMatches());
> {code}
>
> input is of type PBegin.
> The above code matches 0 files even though, from the glob, its clear it
> should match all files. I suspect its because of line 227, where only the
> first parent folder is checked while is could be an asterix in a glob. I
> believe the right behaviour should be to check all parent folder and use the
> first one that exists.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
