[
https://issues.apache.org/jira/browse/BEAM-7776?focusedWorklogId=287994&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-287994
]
ASF GitHub Bot logged work on BEAM-7776:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/19 15:05
Start Date: 02/Aug/19 15:05
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #9116: [BEAM-7776]
Stop Using Perfkit in IOIT
URL: https://github.com/apache/beam/pull/9116#discussion_r310151405
##########
File path: .test-infra/kubernetes/kubernetes.sh
##########
@@ -0,0 +1,91 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# Set of common operations that CI needs to invoke when using Kubernetes.
+# The operations can be invoked using a provided kubeconfig file
+# and kubernetes namespace.
+#
+# Specify the following environment variables to override defaults:
+# - KUBECONFIG: path to .kube/config file (default: $HOME/.kube/config)
+# - KUBERNETES_NAMESPACE: namespace to be used (default: default)
+set -euxo pipefail
+
+KUBECONFIG="${KUBECONFIG:=$HOME/.kube/config}"
+KUBERNETES_NAMESPACE="${KUBERNETES_NAMESPACE:=default}"
+KUBECTL="kubectl --kubeconfig=$KUBECONFIG --namespace=$KUBERNETES_NAMESPACE"
+
+function retry() {
+ local command=$1
+ local max_retries=$2
+ local sleep_time=$3
+
+ for ((i = 1; i <= $max_retries; i++)); do
Review comment:
Can you evaluate (lint) the script with `shellcheck` and fix the
suggestions. You can do it online too via https://www.shellcheck.net/ but
probably better to have it installed locally too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 287994)
Time Spent: 6h 40m (was: 6.5h)
> Implement Kubernetes setup/teardown code to gradle/jenkins tasks.
> ------------------------------------------------------------------
>
> Key: BEAM-7776
> URL: https://issues.apache.org/jira/browse/BEAM-7776
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Lukasz Gajowy
> Assignee: Lukasz Gajowy
> Priority: Major
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> Currently this is done by Perfkit Benchmarker but can be easily moved to
> Beam's codebase and a set of fine-grained gradle tasks. Those could be then
> invoked by Jenkins giving more elasticity to our tests and making Perkfit
> totally obsolete in IOITs.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
