[ https://issues.apache.org/jira/browse/BEAM-3489?focusedWorklogId=288887&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-288887 ]
ASF GitHub Bot logged work on BEAM-3489: ---------------------------------------- Author: ASF GitHub Bot Created on: 05/Aug/19 11:44 Start Date: 05/Aug/19 11:44 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #8370: [BEAM-3489] add PubSub messageId in PubsubMessage URL: https://github.com/apache/beam/pull/8370#issuecomment-518200929 Add another constructor to PubsubUnboundedSource where you pass in a boolean as to whether you need the message id and update the getOuptutCoder to look at this property selecting between the 4 pubsub message coder variants. You'll also want to update https://github.com/apache/beam/blob/667bf8569460e959f02229a835f42fd4ad2ad9a4/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java#L1146 to look at this property and select between the coder with the message id and attributes or just the attributes coder based upon the new boolean that you added. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 288887) Time Spent: 6.5h (was: 6h 20m) > Expose the message id of received messages within PubsubMessage > --------------------------------------------------------------- > > Key: BEAM-3489 > URL: https://issues.apache.org/jira/browse/BEAM-3489 > Project: Beam > Issue Type: New Feature > Components: io-java-gcp > Reporter: Luke Cwik > Assignee: Thinh Ha > Priority: Minor > Labels: newbie, starter > Time Spent: 6.5h > Remaining Estimate: 0h > > This task is about passing forward the message id from the pubsub proto to > the java PubsubMessage. > Add a message id field to PubsubMessage. > Update the coder for PubsubMessage to encode the message id. > Update the translation from the Pubsub proto message to the Dataflow message: > https://github.com/apache/beam/blob/2e275264b21db45787833502e5e42907b05e28b8/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubUnboundedSource.java#L976 -- This message was sent by Atlassian JIRA (v7.6.14#76016)