[
https://issues.apache.org/jira/browse/BEAM-7495?focusedWorklogId=289172&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-289172
]
ASF GitHub Bot logged work on BEAM-7495:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/19 20:12
Start Date: 05/Aug/19 20:12
Worklog Time Spent: 10m
Work Description: aryann commented on pull request #9156: [BEAM-7495] Add
fine-grained progress reporting
URL: https://github.com/apache/beam/pull/9156#discussion_r310770199
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java
##########
@@ -210,20 +218,35 @@ private synchronized boolean readNextRecord() throws
IOException {
return false;
}
- // N.B.: For simplicity, we update fractionConsumed once a new
response is fetched, not
- // when we reach the end of the current response. In practice, this
choice is not
- // consequential.
- fractionConsumed = fractionConsumedFromLastResponse;
- ReadRowsResponse nextResponse = responseIterator.next();
+ fractionConsumedFromPreviousResponse =
fractionConsumedFromCurrentResponse;
+ ReadRowsResponse currentResponse = responseIterator.next();
decoder =
DecoderFactory.get()
.binaryDecoder(
-
nextResponse.getAvroRows().getSerializedBinaryRows().toByteArray(), decoder);
- fractionConsumedFromLastResponse = getFractionConsumed(nextResponse);
+
currentResponse.getAvroRows().getSerializedBinaryRows().toByteArray(), decoder);
+
+ // Since we now have a new response, reset the row counter for the
current response.
+ rowsReadFromCurrentResponse = 0L;
+
+ totalRowCountFromCurrentResponse =
currentResponse.getAvroRows().getRowCount();
+ fractionConsumedFromCurrentResponse =
getFractionConsumed(currentResponse);
Review comment:
Done. I ended up using Preconditions#checkArgument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 289172)
Time Spent: 10h (was: 9h 50m)
Remaining Estimate: 494h (was: 494h 10m)
> Add support for dynamic worker re-balancing when reading BigQuery data using
> Cloud Dataflow
> -------------------------------------------------------------------------------------------
>
> Key: BEAM-7495
> URL: https://issues.apache.org/jira/browse/BEAM-7495
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Aryan Naraghi
> Assignee: Aryan Naraghi
> Priority: Major
> Original Estimate: 504h
> Time Spent: 10h
> Remaining Estimate: 494h
>
> Currently, the BigQuery connector for reading data using the BigQuery Storage
> API does not support any of the facilities on the source for Dataflow to
> split streams.
>
> On the server side, the BigQuery Storage API supports splitting streams at a
> fraction. By adding support to the connector, we enable Dataflow to split
> streams, which unlocks dynamic worker re-balancing.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
