[
https://issues.apache.org/jira/browse/BEAM-7874?focusedWorklogId=290435&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290435
]
ASF GitHub Bot logged work on BEAM-7874:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/19 12:33
Start Date: 07/Aug/19 12:33
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #9218: [BEAM-7874],
[BEAM-7873] Distributed FnApiRunner bugfixs
URL: https://github.com/apache/beam/pull/9218#discussion_r311524807
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -1319,55 +1320,62 @@ def stop_worker(self):
@WorkerHandler.register_environment(common_urns.environments.DOCKER.urn,
beam_runner_api_pb2.DockerPayload)
class DockerSdkWorkerHandler(GrpcWorkerHandler):
+
+ _lock = threading.Lock()
Review comment:
Add some comments as to why this is needed. Is it to workaround subprocess
issues with Python 2? If so, perhaps lift it up as an appropriately named
module global (as it should be shared with the SubProcess worker handler
below).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 290435)
> FnApi only supports up to 10 workers
> ------------------------------------
>
> Key: BEAM-7874
> URL: https://issues.apache.org/jira/browse/BEAM-7874
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Blocker
> Fix For: 2.15.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Because max_workers of grpc servers are hardcoded to 10, it only supports up
> to 10 workers, and if we pass more direct_num_workers greater than 10,
> pipeline hangs, because not all workers get connected to the runner.
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/fn_api_runner.py#L1141]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
