[
https://issues.apache.org/jira/browse/BEAM-5980?focusedWorklogId=290460&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290460
]
ASF GitHub Bot logged work on BEAM-5980:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/19 13:24
Start Date: 07/Aug/19 13:24
Worklog Time Spent: 10m
Work Description: kkucharc commented on pull request #9286: [BEAM-5980]
Remove redundant combine tests
URL: https://github.com/apache/beam/pull/9286#discussion_r311549710
##########
File path: .test-infra/jenkins/job_LoadTests_Combine_Flink_Python.groovy
##########
@@ -149,22 +83,15 @@ def batchLoadTestJob = { scope, triggeringContext ->
scope.description('Runs Python Combine load tests on Flink runner in batch
mode')
commonJobProperties.setTopLevelMainJobProperties(scope, 'master', 240)
- def numberOfWorkers = 16
- def scaledNumberOfWorkers = 5
def datasetName = loadTestsBuilder.getBigQueryDataset('load_test',
triggeringContext)
infra.prepareSDKHarness(scope, CommonTestProperties.SDK.PYTHON,
dockerRegistryRoot, dockerTag)
infra.prepareFlinkJobServer(scope, flinkVersion, dockerRegistryRoot,
dockerTag)
- infra.setupFlinkCluster(scope, jenkinsJobName, flinkDownloadUrl,
pythonHarnessImageTag, jobServerImageTag, numberOfWorkers)
- def testConfigs = loadTestConfigurationsSixteenWorkers(datasetName)
- for (config in testConfigs) {
- loadTestsBuilder.loadTest(scope, config.title, config.runner,
CommonTestProperties.SDK.PYTHON, config.jobProperties, config.itClass)
- }
-
- infra.scaleCluster(scope, jenkinsJobName, scaledNumberOfWorkers)
+ def numberOfWorkers = 16
Review comment:
What do you think about making it global again and put in parallelism param
in each test configuration?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 290460)
Time Spent: 1h 10m (was: 1h)
> Add load tests for Core Apache Beam opertaions
> -----------------------------------------------
>
> Key: BEAM-5980
> URL: https://issues.apache.org/jira/browse/BEAM-5980
> Project: Beam
> Issue Type: New Feature
> Components: testing
> Reporter: Lukasz Gajowy
> Assignee: Lukasz Gajowy
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This involves adding a suite of load tests described in this proposal:
> [https://s.apache.org/load-test-basic-operations]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
