[
https://issues.apache.org/jira/browse/BEAM-7912?focusedWorklogId=290620&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290620
]
ASF GitHub Bot logged work on BEAM-7912:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/19 17:38
Start Date: 07/Aug/19 17:38
Worklog Time Spent: 10m
Work Description: Ardagan commented on pull request #9280: [BEAM-7912]
Optimize GroupIntoBatches for batch Dataflow pipelines.
URL: https://github.com/apache/beam/pull/9280#discussion_r311677973
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -422,6 +428,14 @@ protected DataflowRunner(DataflowPipelineOptions options)
{
// Dataflow Streaming runner overrides the SPLITTABLE_PROCESS_KEYED
transform
// natively in the Dataflow service.
} else {
+ overridesBuilder
Review comment:
Can you extract whole if/else or contents of if/else cases into separate
methods please? First if case is pretty big to be worth moving to separate
method/class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 290620)
Time Spent: 50m (was: 40m)
> Optimize GroupIntoBatches for batch Dataflow pipelines
> ------------------------------------------------------
>
> Key: BEAM-7912
> URL: https://issues.apache.org/jira/browse/BEAM-7912
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The GroupIntoBatches transform can be significantly optimized on Dataflow
> since it always ensures that a key K appears in only one bundle after a
> GroupByKey. This removes the usage of state and timers in the generic
> GroupIntoBatches transform.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
