[
https://issues.apache.org/jira/browse/BEAM-7917?focusedWorklogId=291861&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291861
]
ASF GitHub Bot logged work on BEAM-7917:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/19 07:00
Start Date: 09/Aug/19 07:00
Worklog Time Spent: 10m
Work Description: sadovnychyi commented on pull request #9294:
[BEAM-7917] Fix datastore writes failing on retry
URL: https://github.com/apache/beam/pull/9294#discussion_r312351280
##########
File path: sdks/python/apache_beam/io/gcp/datastore/v1new/helper.py
##########
@@ -100,6 +100,10 @@ def write_mutations(batch, throttler, rpc_stats_callback,
throttle_delay=1):
try:
start_time = time.time()
+ if batch._status == batch._FINISHED:
Review comment:
Agree. I think it's a very good idea to propagate this changes to
datastoreio.py as well and avoid building `_batch` there at all, and just
accumulate `_mutations` or `_batch_mutations` which we would pass to
`write_mutations` and build a new batch every time. This will probably involve
test changes as well.
Happy to work on it but would like to confirm this idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 291861)
Time Spent: 50m (was: 40m)
> Python datastore v1new fails on retry
> -------------------------------------
>
> Key: BEAM-7917
> URL: https://issues.apache.org/jira/browse/BEAM-7917
> Project: Beam
> Issue Type: Bug
> Components: io-py-gcp, runner-dataflow
> Affects Versions: 2.14.0
> Environment: Python 3.7 on Dataflow
> Reporter: Dmytro Sadovnychyi
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Traceback (most recent call last):
> File "apache_beam/runners/common.py", line 782, in
> apache_beam.runners.common.DoFnRunner.process
> File "apache_beam/runners/common.py", line 454, in
> apache_beam.runners.common.SimpleInvoker.invoke_process
> File
> "/usr/local/lib/python3.7/site-packages/apache_beam/io/gcp/datastore/v1new/datastoreio.py",
> line 334, in process
> self._flush_batch()
> File
> "/usr/local/lib/python3.7/site-packages/apache_beam/io/gcp/datastore/v1new/datastoreio.py",
> line 349, in _flush_batch
> throttle_delay=util.WRITE_BATCH_TARGET_LATENCY_MS // 1000)
> File "/usr/local/lib/python3.7/site-packages/apache_beam/utils/retry.py",
> line 197, in wrapper
> return fun(*args, **kwargs)
> File
> "/usr/local/lib/python3.7/site-packages/apache_beam/io/gcp/datastore/v1new/helper.py",
> line 99, in write_mutations
> batch.commit()
> File
> "/usr/local/lib/python3.7/site-packages/google/cloud/datastore/batch.py",
> line 271, in commit
> raise ValueError("Batch must be in progress to commit()")
> ValueError: Batch must be in progress to commit()
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
