[
https://issues.apache.org/jira/browse/BEAM-7696?focusedWorklogId=293304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293304
]
ASF GitHub Bot logged work on BEAM-7696:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/19 18:30
Start Date: 12/Aug/19 18:30
Worklog Time Spent: 10m
Work Description: lukecwik commented on issue #9019: [BEAM-7696] Prepare
files to stage also in local master of spark runner.
URL: https://github.com/apache/beam/pull/9019#issuecomment-520541917
> > I suggest that we re-use the code in Dataflow and to automatically
convert directory classpath entries into jars:
> >
https://github.com/apache/beam/blob/3e97543d53cf30b7ac072e225d358e8436784220/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java#L256
> >
> > It will likely require some refactoring to make it available to more
runners.
>
> Currently, there exist `detectClassPathResourcesToStage` and
`prepareFilesForStaging` in
[PipelineResources](https://github.com/apache/beam/blob/master/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PipelineResources.java#L51).
Do you mean to do the packaging of directories inside
`detectClassPathResourcesToStage`, so no need to call `prepareFilesForStaging`
manually?
I thought the issue was that the SparkRunner couldn't handle directories but
I misread the conversation above and its related to non-existent files so my
comment doesn't make any sense and no change is needed/wanted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 293304)
Time Spent: 4.5h (was: 4h 20m)
> If classpath directory contains a directory it causes exception in Spark
> runner staging
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-7696
> URL: https://issues.apache.org/jira/browse/BEAM-7696
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Reporter: Wang Yanlin
> Assignee: Wang Yanlin
> Priority: Minor
> Fix For: 2.15.0
>
> Attachments: addJar_exception.jpg, files_contains_dir.jpg
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Run the unit test SparkPipelineStateTest.testBatchPipelineRunningState in
> IntelliJ IDEA on my mac, get the IllegalArgumentException in the console
> output. I check the source code, and find the result of
> _PipelineResources.detectClassPathResourcesToStage_ contains directory, which
> is the cause of the exception.
> See the attached file 'addJar_exception.jpg' for detail, and the result of
> _PipelineResources.detectClassPathResourcesToStage_
> is showed in attached file 'files_contains_dir.jpg' during debug.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
