[
https://issues.apache.org/jira/browse/BEAM-7954?focusedWorklogId=293308&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293308
]
ASF GitHub Bot logged work on BEAM-7954:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/19 18:37
Start Date: 12/Aug/19 18:37
Worklog Time Spent: 10m
Work Description: lukecwik commented on issue #9316: [BEAM-7954] Validate
beam modules to disable guava imports from vendored gRPC
URL: https://github.com/apache/beam/pull/9316#issuecomment-520544758
The idea is good but there are likely other occurrences as well since the
checkstyle in the java precommit is failing. Will wait on an update to fix
other offending locations before merging.
Also, we may need to revert the checkstyle check in the future if a gRPC API
ever requires its own guava type to be passed into it. For now it doesn't seem
to be the case but it might be worthwhile to add a comment to this regard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 293308)
Time Spent: 20m (was: 10m)
> Beam should only use guava imports coming from vendored guava
> -------------------------------------------------------------
>
> Key: BEAM-7954
> URL: https://issues.apache.org/jira/browse/BEAM-7954
> Project: Beam
> Issue Type: Bug
> Components: build-system, sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Fix For: 2.15.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> gRPC vendors guava too and some Beam classes have mistakenly started to use
> guava coming from the vendored gRPC dependency. We should probably restrict
> the use of Guava only to its vendored dependency.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
