[ 
https://issues.apache.org/jira/browse/BEAM-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906254#comment-16906254
 ] 

Neville Li commented on BEAM-7956:
----------------------------------

False alarm. It's indeed an issue with scala automatically unboxing 
{{Float}}/{{Double}}.
See for more info:
https://github.com/spotify/scio/pull/2151

> FloatCoder and DoubleCoder structuralValue doesn't handle NaN
> -------------------------------------------------------------
>
>                 Key: BEAM-7956
>                 URL: https://issues.apache.org/jira/browse/BEAM-7956
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 2.14.0
>            Reporter: Neville Li
>            Priority: Trivial
>
> Comparing {{Float}} and {{Double}} {{NaN}} values always yields {{false}}, 
> even though they serialize consistently to the same byte array.
> {{FloatCoder}} and {{DoubleCoder}} override {{consistentWithEquals}} to 
> {{true}} but doesn't override {{structuralValue}} which return the orignal 
> {{NaN}} and fails comparison.
> This trips {{MutationDetectors}} in tests.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to