ASF GitHub Bot logged work on BEAM-7802:

                Author: ASF GitHub Bot
            Created on: 13/Aug/19 20:01
            Start Date: 13/Aug/19 20:01
    Worklog Time Spent: 10m 
      Work Description: kanterov commented on pull request #9130: [BEAM-7802] 
Expose a method to make an Avro-based PCollection into an Schema-based one
URL: https://github.com/apache/beam/pull/9130#discussion_r313586430

 File path: 
 @@ -127,7 +127,7 @@ public static FixedBytesField withSize(int size) {
     /** Create a {@link FixedBytesField} from a Beam {@link FieldType}. */
-    public static FixedBytesField fromBeamFieldType(FieldType fieldType) {
+    static FixedBytesField fromBeamFieldType(FieldType fieldType) {
 Review comment:
   If you ask me, I would rather make the whole class protected (or delete it), 
hiding everything, and all user-facing functionality will move to AvroCoder
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 294140)
    Time Spent: 3h  (was: 2h 50m)

> Expose a method to make an Avro-based PCollection into an Schema-based one
> --------------------------------------------------------------------------
>                 Key: BEAM-7802
>                 URL: https://issues.apache.org/jira/browse/BEAM-7802
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Ismaël Mejía
>            Assignee: Ismaël Mejía
>            Priority: Minor
>          Time Spent: 3h
>  Remaining Estimate: 0h
> Avro can infer the Schema for an Avro based PCollection by using the 
> `withBeamSchemas` method, however if the user created a PCollection with Avro 
> objects or IndexedRecord/GenericRecord, he needs to manually set the schema 
> (or coder). The idea is to expose a method in schema.AvroUtils to ease this.

This message was sent by Atlassian JIRA

Reply via email to