[
https://issues.apache.org/jira/browse/BEAM-7969?focusedWorklogId=294161&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294161
]
ASF GitHub Bot logged work on BEAM-7969:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/19 20:21
Start Date: 13/Aug/19 20:21
Worklog Time Spent: 10m
Work Description: ajamato commented on pull request #9330: [BEAM-7969]
Report FnAPI counters as deltas in streaming jobs.
URL: https://github.com/apache/beam/pull/9330#discussion_r313594324
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
##########
@@ -1867,6 +1873,28 @@ private void sendWorkerUpdatesToDataflowService(
cumulativeCounters.extractUpdates(false,
DataflowCounterUpdateExtractor.INSTANCE));
counterUpdates.addAll(
deltaCounters.extractModifiedDeltaUpdates(DataflowCounterUpdateExtractor.INSTANCE));
+ if (hasExperiment(options, "beam_fn_api")) {
+ while (!this.pendingMonitoringInfos.isEmpty()) {
+ final CounterUpdate item = this.pendingMonitoringInfos.poll();
Review comment:
The SDK harness will give you the full value of the counter on each
MonitoringInfo. Don't you need to convert it to a delta, since the last
reported value? Or does setting cumulative have DFE solve this internally?
You might want to confirm with @edre.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 294161)
Time Spent: 20m (was: 10m)
> Streaming Dataflow worker doesn't report FnAPI metrics.
> -------------------------------------------------------
>
> Key: BEAM-7969
> URL: https://issues.apache.org/jira/browse/BEAM-7969
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution, runner-dataflow
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> EOM
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
