[ https://issues.apache.org/jira/browse/BEAM-7711?focusedWorklogId=294889&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294889 ]
ASF GitHub Bot logged work on BEAM-7711: ---------------------------------------- Author: ASF GitHub Bot Created on: 14/Aug/19 17:38 Start Date: 14/Aug/19 17:38 Worklog Time Spent: 10m Work Description: amaliujia commented on pull request #8994: [BEAM-7711] Add DATETIME as a logical type in BeamSQL URL: https://github.com/apache/beam/pull/8994#discussion_r313997918 ########## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/CalciteUtils.java ########## @@ -154,6 +163,7 @@ public static boolean isStringType(FieldType fieldType) { .put(TIME_WITH_LOCAL_TZ, SqlTypeName.TIME_WITH_LOCAL_TIME_ZONE) .put(TIMESTAMP, SqlTypeName.TIMESTAMP) .put(TIMESTAMP_WITH_LOCAL_TZ, SqlTypeName.TIMESTAMP_WITH_LOCAL_TIME_ZONE) + .put(DATETIME, SqlTypeName.TIMESTAMP) Review comment: I cannot find a precious definition of `TIMESTMAP WITHOUT TIME ZONE` from Calcite so I don't really know the difference. However Calcite maps both `TIMESTMAP WITHOUT TIME ZONE` and ``TIMESTMAP WITH TIME ZONE` to `TIMESTAMP` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 294889) Time Spent: 1h 40m (was: 1.5h) > Support DATETIME as a logical type in BeamSQL > --------------------------------------------- > > Key: BEAM-7711 > URL: https://issues.apache.org/jira/browse/BEAM-7711 > Project: Beam > Issue Type: New Feature > Components: dsl-sql > Reporter: Rui Wang > Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > DATETIME as a type represents a year, month, day, hour, minute, second, and > subsecond(millis) > it ranges from 0001-01-01 00:00:00 to 9999-12-31 23:59:59.999. -- This message was sent by Atlassian JIRA (v7.6.14#76016)