[
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296597&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296597
]
ASF GitHub Bot logged work on BEAM-7994:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Aug/19 21:32
Start Date: 16/Aug/19 21:32
Worklog Time Spent: 10m
Work Description: dsnet commented on pull request #9362: [BEAM-7994]
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r314897093
##########
File path: sdks/go/pkg/beam/core/util/reflectx/functions_test.go
##########
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package reflectx
+
+import (
+ "reflect"
+ "testing"
+)
+
+func testFunction() int {
+ return 42
+}
+
+func TestXxx(t *testing.T) {
Review comment:
`TestLoadFunction`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 296597)
Time Spent: 0.5h (was: 20m)
> BEAM SDK has compatibility problems with go1.13
> -----------------------------------------------
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Bill Neubauer
> Assignee: Bill Neubauer
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix
> the team recommended.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
